Repository navigation
feat: ✨ add request example - #156
Merged
Merged
Conversation
lwjohnst86
requested changes
Sep 30, 2026
lwjohnst86
left a comment
lwjohnst86
left a comment
Member
There was a problem hiding this comment.
Nice! Especially for changes to code, you really want to make sure they are atomic, meaning not adding anything that isn't part of that atomic change. So the reformatting of Markdown or the updates to the theme should not be included, and rather made as separate PRs.
DanMazJen
commented
Sep 30, 2026
DanMazJen
left a comment
DanMazJen
left a comment
Contributor
Author
There was a problem hiding this comment.
Will we add the corresponding .parquet file in src/ for future subset tests?
Member
|
@DanMazJen yea, or in |
Contributor
Author
But in another PR, right? Is there more to this PR? 😄 |
signekb
requested changes
Oct 5, 2026
signekb
approved these changes
Oct 5, 2026
Member
|
Its also not test but feat |
lwjohnst86
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add
constrequest.yaml example for future tests on read and subset.Closes #94
Needs a thorough review.
Checklist
just run-all