Update compile instructions for Apple Silicon and Bundler#11
Open
bensheldon wants to merge 1 commit intosegabor:masterfrom
Open
Update compile instructions for Apple Silicon and Bundler#11bensheldon wants to merge 1 commit intosegabor:masterfrom
bensheldon wants to merge 1 commit intosegabor:masterfrom
Conversation
segabor
requested changes
Feb 9, 2022
Owner
segabor
left a comment
segabor
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the amendment. I'm surprised of the new Homebrew location. It turned out HB already wanted to change it but they finally made it on Apple Silicon. See this comment Homebrew/brew#7857 (comment)
Can you please replace the direct path of hunspell library to $(brew --prefix hunspell) so users don't need to figure out where it is installed.
Thanks and appreciated your PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds updated compile/install instructions.