Repository navigation
feat(basepage): withNewWindow / withNewTab - #103
Merged
Merged
Conversation
…estore (#49) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
withNewWindow(opener, body): runs the opener, switches to the new window via handle diff, runs the body, closes the new window, restores the original infinallywithNewTabaliasDeviations from the issue's sketch, deliberately:
Runnablehas no way to run code in the new window, since the switch happens after it returns.TimeoutExceptioninstead of a silent no-op, so a missing window cannot make a test pass without running its assertions.Verified: new BasePageNewWindowTest covers normal open, alias, no window, body throws, opener throws; full suite 563 green.
🤖 Generated with Claude Code