Skip to content

Refactor report styles into separate CSS file - #192

Merged
shossain786 merged 2 commits into
seleniumboot:masterfrom
codingkush:issue-179-extract-css
Oct 22, 2026
Merged

shossain786 merged 2 commits into
seleniumboot:masterfrom
codingkush:issue-179-extract-css

Conversation

@codingkush

Copy link
Copy Markdown
Contributor

What & why

Extracts the report CSS from report-template.html into a dedicated report/report.css resource.

HtmlReportGenerator loads the CSS from the classpath and inlines it into the generated HTML report, so the report remains a single self-contained file. Existing report markup and behavior are unchanged.

Part of #179

Type of change

  • Bug fix
  • New feature (opt-in, aligned with the framework philosophy)
  • Documentation
  • Internal refactor / test coverage

Checklist

  • All existing tests pass (mvn clean verify)
  • New behaviour is covered by unit tests
  • No new external dependencies introduced without prior discussion
  • Code follows existing conventions (no new frameworks, minimal abstraction)
  • No breaking changes to @SeleniumBootApi public APIs (or a major version bump is justified below)
  • Docs updated if user-facing behaviour changed (docs-site/) — not applicable; this is an internal refactor

Notes for reviewers

  • This PR only extracts the CSS.

  • JavaScript extraction, markup partials, and theme changes will be submitted separately.

  • HtmlReportGenerator replaces the {{REPORT_CSS}} placeholder with the classpath CSS content.

  • The generated report remains a single self-contained HTML file.

  • No runtime behavior or public API changes are included.

  • The template uses valid HTML newlines around the CSS placeholder:

    <style>
    {{REPORT_CSS}}
    </style>

Validation

  • mvn clean verify ran all 790 tests successfully:

    • 0 failures
    • 0 errors
    • 0 skipped tests
  • The build exited during the final Maven GPG signing phase because GPG signing is not configured in the local environment. This is unrelated to this PR.

  • Focused report tests passed:

    mvn -q -Dtest=HtmlReportGeneratorTest,ReportTabBehaviourTest test
    

@codingkush
codingkush force-pushed the issue-179-extract-css branch from db856d8 to 7888e00 Compare October 21, 2026 17:19
Carries the seleniumboot#189 tag CSS into report.css.
@shossain786
shossain786 merged commit 2184e8b into seleniumboot:master Oct 22, 2026
shossain786 added a commit to codingkush/selenium-boot that referenced this pull request Oct 22, 2026
seleniumboot#192 landed as a squash; keep this branch's identical CSS extraction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants