Repository navigation
Refactor report styles into separate CSS file - #192
Merged
shossain786 merged 2 commits intoOct 22, 2026
Merged
Conversation
codingkush
force-pushed
the
issue-179-extract-css
branch
from
October 21, 2026 17:19
db856d8 to
7888e00
Compare
Carries the seleniumboot#189 tag CSS into report.css.
shossain786
added a commit
to codingkush/selenium-boot
that referenced
this pull request
Oct 22, 2026
seleniumboot#192 landed as a squash; keep this branch's identical CSS extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Extracts the report CSS from
report-template.htmlinto a dedicatedreport/report.cssresource.HtmlReportGeneratorloads the CSS from the classpath and inlines it into the generated HTML report, so the report remains a single self-contained file. Existing report markup and behavior are unchanged.Part of #179
Type of change
Checklist
mvn clean verify)@SeleniumBootApipublic APIs (or a major version bump is justified below)docs-site/) — not applicable; this is an internal refactorNotes for reviewers
This PR only extracts the CSS.
JavaScript extraction, markup partials, and theme changes will be submitted separately.
HtmlReportGeneratorreplaces the{{REPORT_CSS}}placeholder with the classpath CSS content.The generated report remains a single self-contained HTML file.
No runtime behavior or public API changes are included.
The template uses valid HTML newlines around the CSS placeholder:
Validation
mvn clean verifyran all 790 tests successfully:The build exited during the final Maven GPG signing phase because GPG signing is not configured in the local environment. This is unrelated to this PR.
Focused report tests passed: