Repository navigation
Refactor report by extracting CSS and JavaScript - #193
Merged
shossain786 merged 5 commits intoOct 22, 2026
Merged
Conversation
Carries the seleniumboot#189 tag CSS into report.css.
Carries the seleniumboot#189 tag JS into report.js.
seleniumboot#192 landed as a squash; keep this branch's identical CSS extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Extracts the report JavaScript from
report-template.htmlinto a dedicatedreport/report.jsresource.HtmlReportGeneratorloads the JavaScript from the classpath and inlines it into the generated HTML report. This keeps the report as a single self-contained file while preserving existing behavior for tabs, filters, search, trend charts, lightbox handling, dark mode, and failure panels.This PR is based on the CSS extraction PR and contains only the JavaScript extraction.
Part of #179
Type of change
Checklist
mvn clean verify)@SeleniumBootApipublic APIs (or a major version bump is justified below)docs-site/) — not applicable; this is an internal refactorNotes for reviewers
This PR only extracts the JavaScript.
CSS extraction is included through the preceding PR.
Markup partials, theme updates, and offline Chart.js bundling will be submitted separately.
HtmlReportGeneratorreplaces the{{REPORT_JS}}placeholder with the classpath JavaScript content.The generated report remains a single self-contained HTML file.
Existing report behavior is preserved.
No runtime behavior or public API changes are included.
The template uses valid HTML newlines around the JavaScript placeholder:
Validation
mvn clean verifyran all 790 tests successfully:The build exited during the final Maven GPG signing phase because GPG signing is not configured in the local environment. This is unrelated to this PR.
Focused report tests passed: