Repository navigation
feat(tracing): failure traces on by default in CI - #198
Merged
Merged
Conversation
When tracing.enabled is not set, failed-test traces are recorded in CI and stay off locally. An explicit true/false still wins; captureOnPass is unchanged. The GitHub Actions summary uses the same check so the run link appears with the default. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #130.
When
tracing.enabledis not set inselenium-boot.yml, traces for failed tests are now recorded in CI (CiEnvironmentDetector.isCI()). Local runs are unchanged. An explicitenabled: true|falsealways wins.captureOnPassstays off.Tracing.enabledbecomes a nullableBooleanso unset can be told apart fromfalse;isEnabled()still returns the explicit value.isEffectivelyEnabled()used by the TestNG listener, the JUnit 5 extension andGitHubActionsSummary(so the run-page link from feat(ci): link the failure summary to the run's trace artifacts (#130) #195 appears with the default).target/traces/in CI on failures (screenshots embedded), so worth a minor-version changelog line at release.Tests:
TracingConfigTestcovers unset/explicit × CI/local. Full unit suite 807/807.🤖 Generated with Claude Code