Repository navigation
fix(precondition): restore cached session on the captured origin - #225
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh driver starts on
about:blank, whereaddCookieand localStorage access fail.SessionCache.restoreswallowed those errors, so every test after the first on a thread ran logged out.Fix: store the origin at capture; on restore, navigate there first if the browser is elsewhere.
Proof: new
SessionCacheLiveTest(real headless Chrome) fails on master (cookie not restored) and passes with the fix. Unit suite: 812 passed, 0 failed. Skips when Chrome is unavailable.Found while writing the SSO recipe (#224).
🤖 Generated with Claude Code