Repository navigation
fix(report): stop tag pills throwing in single-test exports - #249
Merged
Merged
Conversation
Exported files kept the tag pills' filterByTag handler, which only exists in the full report, so clicking a pill threw a ReferenceError. Pills now just stop propagation, so they also no longer collapse the detail row. Also drops a test that only wrote a sample report into target/, and documents the "Download this test" button. Follow-up to #248. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #248.
What & why
onclick="filterByTag(...)". That function only exists in the full report, so clicking a pill in the export threwReferenceError: filterByTag is not defined. Pills in the export now only stop propagation, so clicking one doesn't collapse the detail row either.generate_writesSampleReportToTargetForManualVerification. It only wrote a sample report intotarget/and asserted nothing real.reporting/html-report.md.Verification
ReferenceError.filterByTaghandlers. Pills leave the detail open, the row click still toggles it, and the screenshot lightbox still opens.mvn clean verifypasses.🤖 Generated with Claude Code