Repository navigation
feat(config): -Dbrowser switches the browser from the command line - #252
Merged
Merged
Conversation
-Dbrowser=firefox (or -Dselenium.boot.browser=firefox, which wins if both are set) now replaces browser.name from the file, profiles and SeleniumBootDefaults, and clears browser.matrix so one browser means one browser. Blank is ignored; the value is trimmed and lower-cased. Docs: new "Switching browser from the command line" section; the Gradle snippets now forward browser and selenium.boot.profile (the latter was documented but never forwarded, so it did nothing under Gradle). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvn test -Dbrowser=firefoxused to be silently ignored (#247 removed the docs that claimed it worked). Now it works.Behaviour
-Dbrowser=<name>or-Dselenium.boot.browser=<name>. The namespaced key wins if both are set.browser.namefrom yml, profiles andSeleniumBootDefaults.browser.matrix, so asking for one browser runs only that browser.Docs
configuration.md: new "Switching browser from the command line" section.gradle.md: the snippets now forwardbrowserandselenium.boot.profile. Before this, the documented./gradlew test -Dselenium.boot.profile=firefoxnever reached the test JVM.Verification
ConfigurationLoaderTestcases. On master, 5 fail (the blank-value case passes either way), and all pass with the change.mvn clean installis green.selenium-boot-starter(yml sayschrome), watching driver processes duringmvn test -Dbrowser=firefox:chromewas used).junit-xmlbroken anchor remains).🤖 Generated with Claude Code