Repository navigation
ci: add SonarCloud analysis with JaCoCo coverage - #253
Merged
Merged
Conversation
- jacoco-maven-plugin writes target/site/jacoco/jacoco.xml during mvn test
- surefire argLine now carries @{argLine} so the JaCoCo agent attaches
- sonar.* properties in the pom (org seleniumboot, key seleniumboot_selenium-boot)
- new sonar.yml workflow; skips cleanly when SONAR_TOKEN is absent (forks)
Agreed in #251.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SonarCloud, as agreed in #251.
Changes
jacoco-maven-plugin0.8.13 writestarget/site/jacoco/jacoco.xmlduringmvn test.argLineis now@{argLine} ...so the JaCoCo agent attaches. An empty default keeps-Djacoco.skip=trueworking.sonar.*properties in the pom: organizationseleniumboot, project keyseleniumboot_selenium-boot..github/workflows/sonar.ymlruns on master pushes and PRs. IfSONAR_TOKENis missing (fork PRs, or before setup) it skips instead of failing.Verified locally
mvn verify -Dgpg.skip=true: 896 tests, 0 failures. jacoco.xml written, 57.9% line coverage.-Djacoco.skip=truebuild still passes.Not verified: the Sonar scan itself. It needs the SonarCloud project and token first:
seleniumbootGitHub org → addselenium-boot. Check that the org/project keys match the pom.SONAR_TOKENrepo secret.🤖 Generated with Claude Code