Skip to content

Add 'package com.example' to getting-started.md - #48

Closed
GameMaster97 wants to merge 1 commit into
seleniumboot:masterfrom
GameMaster97:patch-2
Closed

GameMaster97 wants to merge 1 commit into
seleniumboot:masterfrom
GameMaster97:patch-2

Conversation

@GameMaster97

Copy link
Copy Markdown

Lack of package was breaking testng.xml

Closes #47

Type of change

  • Bug fix
  • New feature (opt-in, aligned with the framework philosophy)
  • Documentation
  • Internal refactor / test coverage

Checklist

  • All existing tests pass (mvn clean verify)
  • New behaviour is covered by unit tests
  • No new external dependencies introduced without prior discussion
  • Code follows existing conventions (no new frameworks, minimal abstraction)
  • No breaking changes to @SeleniumBootApi public APIs (or a major version bump is justified below)
  • Docs updated if user-facing behaviour changed (docs-site/)

Notes for reviewers

first time doing a pull request

@shossain786

Copy link
Copy Markdown
Contributor

Thanks for this — nice first PR, and you read #47 correctly.

The problem is #47 itself was stale by the time you saw it: my local checkout hadn't pulled #44 (merged 09-12) yet, which had already rewritten this whole Step 3 example independently. On current master, SmokeTest.java lives at src/test/java/SmokeTest.java (no subfolder) on purpose — no package needed — and testng.xml already references it unqualified (<class name="SmokeTest"/>).

Adding package com.example; here actually breaks it — I tested both ways: passes clean before your change, fails with Cannot find class in classpath: com.example.SmokeTest after.

Could you pull latest master and take a look at the current Step 3 before deciding what to do with this PR? If you're up for another one, #41 is still open and genuinely unfixed (the sample config is missing a required execution.mode field).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getting-started.md's LoginTest.java example is missing 'package com.example;', breaking testng.xml's class reference

2 participants