You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add 'package com.example' to getting-started.md - #48
Thanks for this — nice first PR, and you read #47 correctly.
The problem is #47 itself was stale by the time you saw it: my local checkout hadn't pulled #44 (merged 09-12) yet, which had already rewritten this whole Step 3 example independently. On current master, SmokeTest.java lives at src/test/java/SmokeTest.java (no subfolder) on purpose — no package needed — and testng.xml already references it unqualified (<class name="SmokeTest"/>).
Adding package com.example; here actually breaks it — I tested both ways: passes clean before your change, fails with Cannot find class in classpath: com.example.SmokeTest after.
Could you pull latest master and take a look at the current Step 3 before deciding what to do with this PR? If you're up for another one, #41 is still open and genuinely unfixed (the sample config is missing a required execution.mode field).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lack of package was breaking testng.xml
Closes #47
Type of change
Checklist
mvn clean verify)@SeleniumBootApipublic APIs (or a major version bump is justified below)docs-site/)Notes for reviewers
first time doing a pull request