Repository navigation
deps: bump selenium-java 4.40.0 -> 4.49.0 - #56
Merged
Merged
Conversation
The naive version bump didn't compile: Selenium 4.49.0 no longer ships the devtools-v144 CDP module NetworkMock/DeviceEmulator hardcoded imports against (it bundles v151/v153 now). Repointed both files at v153, the newer of the two bundled versions. That surfaced a real CDP API change: v153's Emulation.setDeviceMetricsOverride() gained two trailing optional parameters (scrollbarType and a new bool) versus v144 — added Optional.empty() for both, preserving existing default behavior. Verified: `mvn clean test` — 508/508 tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selenium-javawas pinned 9 releases behind upstream (4.40.0 vs 4.49.0).devtools-v144CDP module thatNetworkMockandDeviceEmulatorimport against directly (it now bundles v151/v153). Repointed both at v153.Emulation.setDeviceMetricsOverride()gained two trailing optional parameters in v153 vs v144. AddedOptional.empty()for both — same default behavior as before, just matching the new arity.Why
Raised while auditing dependency freshness across the ecosystem — see companion PR #55 (Dependabot for
maven), which exists specifically so this kind of drift shows up as a PR instead of a manual audit next time.Test plan
mvn clean test— 508/508 tests passgrep -rn "v144"clean after the change)🤖 Generated with Claude Code