Repository navigation
feat(config): zero-config first run — make selenium-boot.yml optional - #66
Merged
Merged
Conversation
- No default selenium-boot.yml anywhere -> run on built-in defaults and print one notice line. A requested profile / explicit path that is missing still throws (a typo must not silently run on defaults). - Fields a file omits (and empty files) fall back to: browser.name=chrome (unless browser.matrix set), execution.mode=local, timeouts 10s/30s. Present-but-invalid values (unknown mode, negative timeout) still fail. - SeleniumBootDefaults overrides take precedence over built-ins and now apply before validation. - Adds ConfigurationLoader.load(File, ClassLoader) for tests. Traces back to #41/#43/#47 (cold-start friction on the config file). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
selenium-boot.ymlis no longer required.ConfigurationLoadernow:-Dselenium.boot.config, no profile, none in working dir/classpath) → runs on built-in defaults and prints one notice line.browser.name=chrome(skipped whenbrowser.matrixis set),execution.mode=local,timeouts.explicit=10,timeouts.pageLoad=30.execution.mode, negative timeout).SeleniumBootDefaultsoverrides take precedence over the built-ins and now apply before validation.Adds
ConfigurationLoader.load(File workingDir, ClassLoader)so the no-file path is testable.Why
#41, #43 and #47 all trace back to the config file being required on first run.
Verification
mvn clean verify: 515 tests, 0 failures (508 existing + 7 new inConfigurationLoaderTest).NullPointerException: Configuration must not be nulland a partial file throwsExecution mode must be specified; both now load.configuration.md,getting-started.md,CLAUDE.md. No changelog entry — to be added at release time.🤖 Generated with Claude Code