Repository navigation
open() names execution.baseUrl when the site is unreachable - #84
Merged
Merged
Conversation
…he key is missing Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wrong
execution.baseUrlsurfaced as a barenet::ERR_NAME_NOT_RESOLVED. Now:Could not reach <url> (ERR_NAME_NOT_RESOLVED) — check execution.baseUrl in selenium-boot.yml …, original error kept as the cause.BaseUrlNavigation(require + go) used by BaseTest, BaseJUnit5Test, BaseCucumberSteps, BaseConditions. Recognises Chrome/Edge net errors and FirefoxdnsNotFound/connectionFailure; unrelated driver errors are rethrown untouched.BaseJUnit5Test.open()with no baseUrl (no null check before; Zero-config quickstart can't run as written: with no selenium-boot.yml, Step 3's open() throws "baseURL is null or empty" #77 only covered BaseTest).Verified: 539 unit tests pass (6 new). End to end: a generated project pointed at
https://razatechservices.com(the reporter's case) run against a 3.5.98-test build prints the new message.🤖 Generated with Claude Code