Repository navigation
docs: fix getWait()/WaitEngine mismatch, document waitForNetworkIdle/waitForResponse - #87
Merged
Merged
Conversation
…Engine mismatch wait-engine.md, base-page.md and migration/from-selenium-testng.md all called getWait().waitForVisible(...) etc. — but BasePage/BaseTest (the TestNG audience these guides target) never had a getWait() method. The real API is the static WaitEngine.waitForVisible(...), already used correctly in BasePage's own source. Every example in these three guides would have failed to compile as written. (getWait() genuinely exists on BaseJUnit5Test/BaseCucumberSteps, returning a plain WebDriverWait — junit5.md and cucumber.md already describe that correctly and are untouched.) wait-engine.md also documented a getWait(int) timeout override that never existed anywhere in the codebase; replaced with the real per-call Duration overrides on waitForNetworkIdle/waitForResponse. Adds the Network section to wait-engine.md for waitForNetworkIdle()/ waitForResponse() (v3.6.0). Verified: npm run build (docusaurus) succeeds; grep confirms no getWait() call remains in the three fixed files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three docs guides (
wait-engine.md,base-page.md,migration/from-selenium-testng.md) calledgetWait().waitForVisible(...)etc., butBasePage/BaseTestnever had agetWait()method — the real API is the staticWaitEngine.waitForVisible(...), already used correctly inBasePage's own source. Every example in these three guides would have failed to compile as written.getWait()genuinely exists onBaseJUnit5Test/BaseCucumberSteps(returns a plainWebDriverWait) —junit5.md/cucumber.mdalready describe that correctly and are untouched.wait-engine.mdalso documented agetWait(int)timeout override that never existed anywhere in the codebase — replaced with the real per-callDurationoverrides.Also adds the missing Network section to
wait-engine.mdforwaitForNetworkIdle()/waitForResponse()(v3.6.0, released but only in the changelog until now).Verification
npm run build(docusaurus) succeeds; grep confirms nogetWait()call remains in the three fixed files.🤖 Generated with Claude Code