Refactor table preprocessor - #43
Merged
Merged
Conversation
Keep plain Markdown consumers on the original prose while styling Supported, Not supported, and None during HTML render.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
sembr-org | 02bf54a | Jul 21 2026, 09:20 AM |
There was a problem hiding this comment.
Pull request overview
Refactors how the SemBr specification’s FAQ comparison table is rendered by moving HTML injection from a string preprocessor in the content loader into the unified Remark pipeline, so the stored plain Markdown body remains untouched while rendered HTML gains accessible support indicators.
Changes:
- Move “Supported / Not supported / None” table-cell rendering into
remarkSembrvia an AST transform (injecting accessible HTML). - Remove
preprocessForRendering()from the content loader and render the fetched spec source directly. - Update global table/list styling to improve wrapping and align support-indicator styling across
<mark>and<em>.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles/global.css | Adds balanced wrapping for list items and the 2nd table column; updates selectors to style support indicators for both <mark> and <em>. |
| src/lib/remark-sembr.ts | Adds a tableCell visitor that replaces specific support-status text with accessible HTML indicators; renames RFC 2119 constants for clarity. |
| src/content.config.ts | Removes string-based table preprocessing and renders the fetched specification Markdown directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.