Skip to content

[UIK-5355][input-number] typed or incremented/decremented value's precision is equal to step precision#3023

Open
slizhevskyv-semrush wants to merge 1 commit into
release/v17from
UIK-5355/input-number-decimal-count-aligned-with-step
Open

[UIK-5355][input-number] typed or incremented/decremented value's precision is equal to step precision#3023
slizhevskyv-semrush wants to merge 1 commit into
release/v17from
UIK-5355/input-number-decimal-count-aligned-with-step

Conversation

@slizhevskyv-semrush

Copy link
Copy Markdown
Contributor

Changelog

@semcore/input-number

Fixed

  • Aligned typed, incremented, and decremented value precision with the configured step precision.

Motivation and Context

Typed/incremented/decremented value are now aligned with step's precision.

How has this been tested?

I've added unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

return decimals?.length ?? 0;
}

getNewValue(value) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe dislayValue / formattedValue / etc ?

and let's add return type string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants