Skip to content

docs: add Riverst rebuild spec#76

Open
satra wants to merge 1 commit intomainfrom
codex/rebuild-spec
Open

docs: add Riverst rebuild spec#76
satra wants to merge 1 commit intomainfrom
codex/rebuild-spec

Conversation

@satra
Copy link
Collaborator

@satra satra commented Mar 7, 2026

Summary

  • add a repository-wide rebuild specification for Riverst
  • document current components, features, and supported use cases
  • define target architecture, parity requirements, and phased rebuild plan

Testing

  • not run (documentation-only change)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a foundational document for the future development of the Riverst platform. It establishes a detailed rebuild specification, meticulously documenting the existing system's functionalities and components. The specification then proposes a new target architecture, sets clear engineering and functional goals, and outlines a phased delivery plan, ensuring a structured approach to enhancing the platform's architecture, testability, and deployment while maintaining core product behavior.

Highlights

  • Riverst Rebuild Specification: Added a comprehensive document outlining the plan to rebuild the Riverst platform from scratch.
  • Current System Documentation: Documented the current components, features, and supported use cases of the Riverst platform.
  • Target Architecture and Plan: Defined the target architecture, feature parity requirements, and a phased delivery plan for the Riverst rebuild.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/rebuild-spec.md
    • Added the Riverst Rebuild Specification document.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive and well-structured rebuild specification for the Riverst platform. The document is thorough, covering everything from the current state and feature inventory to a proposed architecture, data models, and a phased delivery plan. My review includes a critical security suggestion regarding JWT storage to better align with the goal of a 'production-grade auth mode', and a medium-severity suggestion to improve the flexibility and inclusivity of the avatar data model. Overall, this is an excellent planning document that will provide clear guidance for the rebuild.

Note: Security Review has been skipped due to the limited scope of the PR.


- checks `/api/auth/status`
- supports Google auth or automatic bypass auth
- stores JWT in local storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Storing JWTs in local storage, as mentioned for the current implementation, makes the application vulnerable to Cross-Site Scripting (XSS) attacks. An attacker could steal the token and impersonate the user. To achieve the 'production-grade auth mode' goal (line 122), I recommend storing the JWT in a secure, HttpOnly cookie. This prevents access from client-side scripts and is a much safer practice. The rebuild provides a great opportunity to make this security enhancement.


- ID
- model URL
- gender or voice-selection metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The gender or voice-selection metadata field is a bit ambiguous. The current avatars.json uses a binary gender field, which is limiting. For the rebuild, I suggest using a more descriptive and flexible field, such as a voice_profile object. This could include attributes like pitch, tone, and accent, or reference a pre-configured voice pack. This change would provide more granular control over the avatar's voice and be more inclusive by decoupling voice from gender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant