Skip to content

Added Sensor HAL for Acc, Mag and Gyr.#7

Open
pankajgoenka wants to merge 3 commits intomasterfrom
feature-hal-sensor
Open

Added Sensor HAL for Acc, Mag and Gyr.#7
pankajgoenka wants to merge 3 commits intomasterfrom
feature-hal-sensor

Conversation

@pankajgoenka
Copy link
Contributor

@pankajgoenka pankajgoenka commented Dec 3, 2015

Added Sensor HAL for Acc, Mag and Gyr.
Modified the SH-Xpresso-LPC54102 project to include HAL files

Signed-off-by: Pankaj Goenka pgoenka@audience.com

riansanderson
riansanderson reviewed Dec 3, 2015
View reviewed changes
embedded/projects/SH-Xpresso-LPC54102/sources/app/sensoracq_t.c Outdated
Copy link
Contributor

@riansanderson riansanderson Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo. Should it be Driver_mag ?

Copy link
Contributor Author

@pankajgoenka pankajgoenka Dec 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is a typo. It should be Driver_Mag. I'm correcting it.

@pankajgoenka
Copy link
Contributor Author

pankajgoenka commented Dec 10, 2015

I think the Driver_Sensor.c needs to be split in to individual sensor types - e.g. Driver_BMC150.c and then use the OSP_BUILD_DRIVER_SENSOR macro to create the descriptor for application use. This scheme needs to be understood properly before implementing.

Done

The definition of SENSOR_FLAG_CONTINUOUS_DATA seems incorrect - if you intended the flag to be at bit position 0 then its value should be 1 and not 0 because value of 0 is meaningless as far as checking for 'flag' is concerned.

I agree with you. Have written to Rian about it since the file was sent to us by him and we retained it as is.

pankajgoenka added a commit that referenced this pull request Dec 10, 2015
@pankajgoenka
Split Driver_Sensor.c into individual files for Accel, Mag and Gyro
895822a 
Moved Driver_Common.h and Driver_Sensor.h into embedded folder
Moved Driver_Sensor.h higher up in the directory structure
Moved sensor pin initialization to Board_SensorIfInit and removed double initialization of I2C pins
Details of other changes are in the pull request #7

Signed-off-by: Pankaj Goenka <pgoenka@audience.com>
@pankajgoenka
Added Sensor HAL for Acc, Mag and Gyr.
f4bf6c7 
Modified the SH-Xpresso-LPC54102 project to include HAL files

Signed-off-by: Pankaj Goenka <pgoenka@audience.com>
@pankajgoenka
Split Driver_Sensor.c into individual files for Accel, Mag and Gyro
921a33f 
Moved Driver_Common.h and Driver_Sensor.h into embedded folder
Moved Driver_Sensor.h higher up in the directory structure
Moved sensor pin initialization to Board_SensorIfInit and removed double initialization of I2C pins
Details of other changes are in the pull request #7

Signed-off-by: Pankaj Goenka <pgoenka@audience.com>
@pankajgoenka
Corrected the copyright message
b7b67f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@riansanderson riansanderson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pankajgoenka @riansanderson