chore(bazel): remove the unused ts_grpcgateway codegen rule#291
Open
philz3906 wants to merge 1 commit into
Open
chore(bazel): remove the unused ts_grpcgateway codegen rule#291philz3906 wants to merge 1 commit into
philz3906 wants to merge 1 commit into
Conversation
The legacy grpc-gateway TypeScript codegen has been superseded by the
protobuf-es codegen (the es_proto rule + protoc-gen-es). The ts_grpcgateway
rule and its tooling are no longer referenced by any target, so remove them:
- the ts_grpcgateway rule from bazel/ts-rules.bzl (and the now-unused
proto_compile_impl load); es_proto is untouched
- the //bazel:ts-grpcgateway-plugin proto_plugin
- the protoc-gen-grpc-gateway-ts Go tool dependency: its blank import in
tools/tools.go, the now-empty tools/go.{mod,sum}, and the isolated
go_tool_deps extension + its use_repo in MODULE.bazel
Verified: es_proto targets still build, `bazel mod tidy` is clean, and the
full //... graph loads with no ts_grpcgateway references remaining.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the now-unused
ts_grpcgatewaylegacy grpc-gateway TypeScript codegen rule and its tooling. This codegen has been superseded by the protobuf-es path (thees_protorule +protoc-gen-es), and no target referencests_grpcgatewayany longer.Removed:
ts_grpcgatewayrule inbazel/ts-rules.bzl(and the now-unusedproto_compile_implload —es_protois untouched).//bazel:ts-grpcgateway-pluginproto_plugin.protoc-gen-grpc-gateway-tsGo tool dependency: its blank import intools/tools.go, the now-emptytools/go.{mod,sum}, and the isolatedgo_tool_depsextension + itsuse_repoinMODULE.bazel.Verification
es_prototargets still build (//bazel/protoc-gen-es/tests:fixture_public_es,//service/common/protos:common_protos_es_proto,//processor/protos:processor_es_proto).bazel mod tidyis clean and the full//...graph loads with nots_grpcgatewayreferences.MODULE.bazel.lockcarries noprotoc-gen-grpc-gateway-tsreferences.Ordering
ts_grpcgateway()targets, so a re-pin of this module doesn't break it.🤖 Generated with Claude Code