feat(ui-dashboard): chart foundation — ECharts base, legend, theme, icons (0.2.0)#301
Merged
Merged
Conversation
….1.2) (#299) Replace the hardcoded `h-0.5 bg-gray-300` connector lines between query functions with `h-px bg-border-color` so they follow the theme (and dark mode) instead of a fixed gray. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Stories for the phase-3a chart foundation: ReactEChartsBase (line + bar, which also exercises ChartLegend), the 8 chart-type icons, the series color palettes, and RefreshButton. `ladle serve` compiles and lists all five cleanly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Charts rendered with ECharts' default palette instead of the sentio theme. The theme was registered via a side-effect-only `import './theme/register'`, but the package marks only *.css as side-effectful, so the bundler tree-shook the import away and registerTheme never ran. Make registration an explicit call: register.ts now exports an idempotent registerSentioTheme(), invoked at EchartsBase module load. Verified registerTheme is present in the built dist. Also fixes the charts barrel to import the kebab-cased theme files (sentio-colors / sentio-theme) — the rename's index.ts update was missed earlier. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
frozenluo
force-pushed
the
dev/frozenluo/charts-foundation-to-ui-dashboard
branch
from
dfbe1f6 to
7e1742c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3a of the charts extraction — moves the framework-level chart foundation into
@sentio/ui-dashboardso the render charts and option panels (phase 3b) can build on it:EchartsBase(ECharts wrapper + imperativeEChartsHandle),ChartLegend,RefreshContext/RefreshButtonsentioColors,sentioTheme(+sentioThemeDark),register(ECharts theme registration)Decoupling from app internals
BarLoading/Buttoncome from@sentio/ui-coreuseDarkModeandisMobilerelocated toui-dashboard/src/utils(both pure)Tooltip(floating-ui) copied toui-dashboard/src/common, adapted to@floating-ui/reactv0.27 (refs.setReference/setFloating)sansFontFamilyinlined into the theme (was the app'snext/fontlib)Deps / version
Adds runtime deps
echarts ^6andreact-resize-detector ^12. Bumps0.1.2 → 0.2.0.Verification
pnpm build(css+js+dts) clean;tsc --noEmitclean forsrc/(only the known unrelated@mswjslib-dts error remains). No proto/private-repo references.Note
App-side backfill is a separate PR.
theme/sentioColorswill not be shimmed to this package in the app, because the app pulls it into a web-worker bundle (must stay free of react/echarts) — the app keeps its own copy there.🤖 Generated with Claude Code