feat(ui-dashboard): migrate value-formatter option panels (0.2.3)#304
Open
frozenluo wants to merge 1 commit into
Open
feat(ui-dashboard): migrate value-formatter option panels (0.2.3)#304frozenluo wants to merge 1 commit into
frozenluo wants to merge 1 commit into
Conversation
Migrate ValueOptions / ValueControls / ValueStringMapping from sentio app into ui-dashboard charts/options. proto ChartConfig_Value*Json types map to ValueConfigLike / ValueStyleLike / ValueFormatterLike / MappingRuleLike; ui-core supplies ComboInput / DisclosurePanel / Checkbox / Button / classNames. The dead ColorSelect mapping branch (commented out in app) is kept commented; its ThemeType/query-value-theme dependency is dropped, so the panels no longer pull in the worker-coupled color theme module. Adds a Value story to OptionPanels.stories. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3b (continued) of the dashboard UI extraction. Migrates the value-formatter option-panel trio from the sentio app into
@sentio/ui-dashboard:ValueOptions— formatter (Number/Date/String) + style/precision/currency + prefix/suffixValueControls—DisclosurePanelwrapper with show-value-label / tooltip-total togglesValueStringMapping— value→text mapping rules editorHow
ChartConfig_Value*Json→ValueConfigLike/ValueStyleLike/ValueFormatterLike/MappingRuleLike(already present intypes/chart.ts).ComboInput/DisclosurePanel/Checkbox/Button/classNames.ColorSelectmapping branch is kept commented; itsThemeType/query-value-themedependency is dropped. This keeps the panels free of the worker-coupled color-theme module (query-value-themeis pulled into the chart web-worker bundle in app and stays app-local).defaultProps→ default parameters; dynamic-key writes cast toRecord<string, any>.Valuestory toOptionPanels.stories.Verification
pnpm build(esm/cjs/dts) clean.tsc --noEmit: 0 errors undersrc/(only the known unrelated@mswjs/interceptorslib-dts error remains).gen/service/sentio/app/@sentio/api-es/'lib/).🤖 Generated with Claude Code