feat(protos)!: remove deprecated DBResponse data/list/entities fields#67
Merged
Merged
Conversation
Regenerate the SDK proto bindings to drop the deprecated `DBResponse` oneof fields `data` (tag 2), `list` (tag 4), and `entities` (tag 6), all superseded by `entity_list` (tag 7). Mirrors sentio-core#258. No SDK consumers read these fields (db-context.ts uses entityData/entityList). Regenerated via sentio-core scripts/sdk-sync.sh; protos + runtime packages build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the SDK proto bindings to drop the three deprecated
DBResponseoneof fields, all superseded byentity_list(tag 7):data(google.protobuf.Struct)list(google.protobuf.ListValue)entities(common.RichStructList)This is the SDK-side codegen for sentio-core#258, which removes the same fields from
processor.proto.Changes
Regenerated via sentio-core
scripts/sdk-sync.sh(bazel run //sentio-sdk:write_gen) against the sentio-core branch carrying the field removal. Only generated files change:packages/protos/processor.proto(vendored copy)packages/protos/src/processor/protos/processor.ts(public@sentio/protos)packages/runtime/src/gen/processor/protos/processor.ts(runtime copy)The
DBResponseoneof retainserror(tag 3) andentity_list(tag 7); the now-unusedListValue/RichStructListimports are auto-pruned. No drift in other generated files.Why it's safe
No SDK consumers read the removed fields —
db-context.tsusesentityData/entityList.packages/protosandpackages/runtimeboth build clean.🤖 Generated with Claude Code