chore(lint): source ignores from .gitignore, drop unused @eslint/compat#183
Merged
Conversation
philz3906
force-pushed
the
dev/philz3906/eslint-gitignore
branch
from
b8f1d3d to
cc026f8
Compare
Use includeIgnoreFile from eslint/config (available since the eslint 10 bump) to feed .gitignore patterns into the flat config, then drop the manual ignore entries it now duplicates (**/dist, **/debug, **/docs, **/types). Also drop **/lib and **/gen, which matched nothing in the repo. Remaining manual ignores (config files, builtin, dotfiles) are not covered by .gitignore and stay. Also remove the unused @eslint/compat devDependency — it was never imported, and includeIgnoreFile now comes from eslint/config directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
philz3906
force-pushed
the
dev/philz3906/eslint-gitignore
branch
from
cc026f8 to
063c4ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Feed
.gitignoreinto the ESLint flat config and remove the now-redundant manual ignores.includeIgnoreFilefromeslint/config(exported there since the eslint 10 bump onmain) and add it as the first config entry with{ gitignoreResolution: true }..gitignorenow covers:**/dist,**/debug,**/docs,**/types.**/liband**/gen— neither directory exists in the repo.@eslint/compatdevDependency. It was never imported;includeIgnoreFilenow comes fromeslint/configdirectly (no replacement dep needed).Remaining manual ignores are intentional — they are not covered by
.gitignore: the config-file globs (**/*.config.{ts,js,cjs,mjs}),**/builtin, and the**/,.*dotfile pattern.Why
The manual
ignoreslist duplicated patterns already in.gitignore, so they drifted out of sync. Sourcing them from.gitignorekeeps a single source of truth, and@eslint/compatwas dead weight.Verification
pnpm lint→ exit 0.src/builtin/*.tsfile is still reported as ignored.eslint/configexportsincludeIgnoreFileat runtime on eslint 10.4.0.🤖 Generated with Claude Code