test: cover PTN_BIND 1/4/5 arity and PTN_WHERE 3/4 arg variants - #42
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sentomk
force-pushed
the
test/bind-where-arity
branch
from
July 31, 2026 05:30
1e5c3ac to
d518316
Compare
Add Single (1 member), Quad (4 members), and Penta (5 members) test structs with PTN_BIND declarations for the previously untested arity overloads. Each gets type-correctness static_asserts and hit/miss guard expressions. Also add PTN_WHERE 3-arg and 4-arg guard tests, completing the full 1-5 arity matrix (1, 2, and 5 were already tested in tests_guard.cpp).
sentomk
force-pushed
the
test/bind-where-arity
branch
from
July 31, 2026 05:32
d518316 to
884d5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PTN_BIND and PTN_WHERE macros support 1-5 member arity, but only
some variants had test coverage. PTN_BIND_1 (single member),
PTN_BIND_4, and PTN_BIND_5 were never exercised, and PTN_WHERE
with 3 or 4 parameters was also missing.
Changes
test structs with PTN_BIND declarations
PTN_WHERE
Testing
All 28 NamedPlaceholder tests pass locally (13 new + 15 existing).
Full test suite also passes.