Skip to content

Comments

feat: Add open_cmd to allow split open#41

Open
echaya wants to merge 1 commit intoserenevoid:masterfrom
echaya:master
Open

feat: Add open_cmd to allow split open#41
echaya wants to merge 1 commit intoserenevoid:masterfrom
echaya:master

Conversation

@echaya
Copy link
Contributor

@echaya echaya commented Jun 13, 2025

  1. refactored private _open_file that support open_cmd
  2. refactored _create_buffer_keymaps

1. refactored private _open_file that support open_cmd
2. refactored _create_buffer_keymaps
@echaya
Copy link
Contributor Author

echaya commented Jun 13, 2025

Hi, I have been using vimwiki for min 5 years and today i realized it has stopped updating so I pulled the trigger to migrate to kiwi.nvim. First of all, thanks a lot for creating this solid repo!

This PR was meant to add and which I use a lot when working with vimwiki. While doing so, i also refactored a bit here and there to make it DRY.

@echaya echaya changed the title refactor to support open_cmd feat: Add open_cmd to allow split open Jun 13, 2025
@serenevoid
Copy link
Owner

Nice work! Glad to see your project. Sorry for my delay in responses though. As I mentioned in some other PR, I couldn't follow up with the pending pull requests and bug fixes. I'll try to resolve them slowly

@echaya
Copy link
Contributor Author

echaya commented Jul 7, 2025

thanks @serenevoid - no rush at all.

completely off the topic, i really love the name of this plugin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants