Repository navigation
Conversation
Contributor
Merging this PR will not alter performance1 warning
Comparing |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #42
import { Parser } from 'markdown-exit/core'also bundles the renderer and presets, becausecorebuilds as one chunk. apps that only callparse(), like Comark, ship code they never run.this adds
markdown-exit/parser, which exportsParser,Tokenand what./parseralready exports (Ruler, the state classes,defaultOptions). it leaves out linkify-it likemarkdown-exit/core, andmarkdown-exitandmarkdown-exit/coredon't change. a test checks that the entry bundles neither the renderer nor the presets and thatParsergives the same tokens asMarkdownExit. the quick start has a short section on it.markdown-exit/coremarkdown-exit/parseresbuild 0.28, minified ESM, gzip -9.
Parserhas nouse(),set()orutils, so markdown-it plugins can't be passed to it as they are. Comark would need a small adapter for its users' plugins, which I'd do on the Comark side.