docs: fix stale enviar_plan() docstring (revision_reforzada claim) - #12
Draft
serpeigd wants to merge 1 commit into
Draft
docs: fix stale enviar_plan() docstring (revision_reforzada claim)#12serpeigd wants to merge 1 commit into
serpeigd wants to merge 1 commit into
Conversation
Said "never for revision_reforzada" while the inline comment 30 lines below already documented the direct-send reversal calling it for both verdicts. Found during this week's engineering-health review. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YT24vMVCQaCPaTXpZGyYP3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
El docstring de
enviar_plan()enmcp/gmail_client.pydecía "ui/app.py only calls this for... never for revision_reforzada", pero el comentario inline 30 líneas más abajo (sobre el bug debody=de Gmail) ya confirmaba que se llama para ambos verdicts desde la reversión de "direct send" pararevision_reforzada(verdocs/decisiones.md). Corrige el docstring para que refleje el comportamiento real: ambos casos llaman a esta función, con el mismo gate de contraseña.Solo documentación — comportamiento sin cambios.
Origen
Hallazgo menor de la revisión semanal de ingeniería de hoy.
Generated by Claude Code