Open
Conversation
jkbecker
commented
Apr 12, 2023
| Memory, | ||
| Io, | ||
| } | ||
| impl fmt::Display for SysResource { |
Contributor
Author
There was a problem hiding this comment.
All of these impls seem really verbose to me... is there a more elegant way to do this?
Contributor
There was a problem hiding this comment.
I think there are some crates that could help (e.g. strum), but it seems ok as-is to me for now. That being said, I am not sure you need either of the impl fmt::Display blocks; nothing broke when I commented them out. 🤔
added 2 commits
April 12, 2023 11:20
shinypb
approved these changes
Apr 12, 2023
Contributor
shinypb
left a comment
shinypb
left a comment
There was a problem hiding this comment.
Neat! I knew you'd be able to dig up some fun stuff. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a few more fun details to squeeze out of
/proc. I'm not done yet but I'm also not happy with a few things that are already there so... feel free to poke at it in the meantime.