Skip to content

Pierces work - #2

Open
Pierce717 wants to merge 18 commits into
mainfrom
pierces-work
Open

Pierce717 wants to merge 18 commits into
mainfrom
pierces-work

Conversation

@Pierce717

Copy link
Copy Markdown
Collaborator

No description provided.

Basically train 4 but with the additional plot for latent space and some changes to the loss function i think? could have been reverted when i was working on it locally
Changed from plotting 1 dimension to all dimensions, generates n images in the output file for each dimension.

@setaremalekiii setaremalekiii left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U are most likely clamping a lot of the logvars so when u graph them they're all cmalped to the same value

@setaremalekiii setaremalekiii left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here ur clamping

added the dimension ranking rotations
Comment thread CVAE/ConvCVAE.py
mu = self.fc_mu(out)
logvar = self.fc_logvar(out)
# another value we can change if needed
logvar = torch.clamp(logvar, min=-10, max=10)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here ur clamping ur logvars. Sorry, didn't mean to double comment on the whole PR, but yes, this line could cause everything to be the same

Comment thread CVAE/PCA_rank.py
os.makedirs(OUT_DIR, exist_ok=True)

# Load latents
Z = np.load(LATENTS_PATH) # (N, 64)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u could print the N here to see how many values are unique as well

Updated to load weights. Note that it defaults to my directory so you need to add the directory through --weight <path>
changed default latent size to 32
comment for __init__
2 options, use PCA or endpoint alignment. PCA identifies general direction of the chromosome to get the current angle of the chromosome and finds rotation needed to align to y-axis. Endpoint uses the endpoints to draw a straight line and finds the angle to make that straight line align to the y-axis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants