feat: package as a standalone Windows app#1
Draft
jscottmiller wants to merge 2 commits into
Draft
Conversation
- Add electron-builder with a Windows portable target (electron-builder.yml) - Unpack ffmpeg-static from asar and rewrite its runtime path so the WebM->MP4 fallback works in the packaged build - Add a build:win script - Add GitHub Actions: CI (typecheck + test) and a Windows build workflow that produces the portable exe artifact and attaches it to v* releases - Document the Windows build (local + CI) in the README
- Extract resolveUnpackedPath() with an anchored regex so only an app.asar path segment is rewritten, not a substring inside an install dir or username; cover it with unit tests (dev no-op, posix, win32, edge) - Regenerate bun.lock to include electron-builder - Pin CI to bun 1.3.14 and install with --frozen-lockfile for reproducibility - Shorten appId to com.pipcast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.