Repository navigation
fix(renovate): use loose versioning for Monero so patch releases are proposed - #270
Merged
Merged
Conversation
…proposed Renovate's regex manager gets no versioning from the marker, so the template renders empty and it falls back to semver-coerced, which truncates four-part Monero tags: v0.18.5.4 coerces to 0.18.5 and compares *equal* to v0.18.5.3 (checked against renovate's own versioning module). Patch releases were therefore never proposed; v0.18.5.3/.4 landed via hand-written PRs. versioning=loose orders them correctly. Monero releases also get an explicit no-automerge rule so a node software bump is always reviewed by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marker here is intact (the dashboard detects
monero-project/monero), but no Renovate PR was ever opened for a Monero release — the v0.18.5.3 and v0.18.5.4 bumps were #267 and #269 by hand.Why patch releases were never proposed
The Monero marker carries no
versioning=, soversioningTemplaterenders empty and Renovate falls back tosemver-coerced. Checked against Renovate's own versioning module:v0.18.5.4>v0.18.5.3?semver-coerced(current default)loose(this PR)So v0.18.5.x patch releases were invisible; v0.18.5.3/.4 came in by hand.
Also adds an explicit
automerge: falserule formonero-project/monero, so a node-software bump is always reviewed by hand (the low-risk automerge rule only matches thegithub-actions/dockerfilemanagers today, so this pins the intent rather than changing behaviour).Verification
renovate-config-validator: passes.matchStringsrun against the new Dockerfile extractmonero-project/monero v0.18.5.4@85f036ba…withversioning=loose, plus expat and unbound with their checksums.Companion: sethforprivacy/simple-monero-wallet-rpc-docker, where the marker had also been deleted.
🤖 Generated with Claude Code