fix: resolve Community Applications scan warnings#10
Merged
Conversation
- browserconfig.xml: the XML declaration was on line 2 (blank first line), which is malformed XML and caused the CA scanner's parse failure. The declaration is now the first line. - Remove unraid/only-fan-controller.xml: a duplicate of templates/only-fan-controller.xml (the scanner saw two templates for one app). README install steps now point at templates/ and Community Apps. - CA listing: set <Name> to 'Only Fan Controller' and trim the long <Overview> to a one-line summary. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the parse-failure and duplicate-template warnings from the CA submission scan, and cleans up the listing title.
Changes
internal/api/static/browserconfig.xmlhad a blank line before its<?xml?>declaration (XML declaration allowed only at the start of the document). It's a favicon asset used by the dashboard, so it's fixed, not removed. All repo XML now validates.unraid/only-fan-controller.xmlwas a second Docker template for the same app; the scanner flagged it. Removed in favor oftemplates/only-fan-controller.xml(the CA-standard location). README install steps updated to point attemplates/+ Community Applications.<Name>is now Only Fan Controller, and the long<Overview>is trimmed to a one-line summary (detail stays in<Description>).After merge
Re-run Validate → Scan at ca.unraid.net/submit — the parse-failure and duplicate warnings should be gone, and the title will read "Only Fan Controller".
🤖 Generated with Claude Code