chore: remove deprecated browserconfig.xml (clears last CA scan warning)#11
Merged
Merged
Conversation
The Community Applications scanner flags every non-template XML in the repo (there is no ignore mechanism), which produced a 'not_unraid_application' warning for browserconfig.xml. It is a deprecated Windows 8/10 pinned-tile config that modern browsers ignore, and it was the only non-template XML in the repo. Removing it and its dangling msapplication-config meta tag leaves only the CA template and ca_profile.xml. Favicons are unaffected; go:embed static/* is a glob so the build is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional cleanup to get a spotless Community Applications scan.
The CA scanner walks the whole repo and flags any XML that isn't an app template (there's no ignore mechanism). The only such file was
internal/api/static/browserconfig.xml— a deprecated Windows 8/10 pinned-tile config that modern browsers ignore — which produced thenot_unraid_application: 1warning.Change
internal/api/static/browserconfig.xmland its now-dangling<meta name="msapplication-config">tag inindex.html..png/.icofiles) are untouched and still work.go:embed static/*is a glob, so the build is unchanged (verifiedgo build ./...).After this, the repo's only XML files are
templates/only-fan-controller.xml(the app) andca_profile.xml(the profile) — a clean scan.Note: this is cosmetic for the scan — the submission already passes (no hard errors, 1 valid app). Skip merging if you'd rather keep browserconfig.
🤖 Generated with Claude Code