Review follow-ups: status freshness in fail-safe window, override reason validation#5
Merged
Merged
Conversation
…idation Two non-blocking mediums from earlier principal reviews: - controlLoop now records successfully-read temperatures during the 'sensor failsafe recovered but restore unconfirmed' window (mirroring the sticky write-failsafe branch), so /api/status never goes stale while the controller is handing control back to the BMC. No failsafe or restore semantics changed. - /api/override reason field is now validated server-side: max 128 chars, control characters rejected (400), free text otherwise - closing the defense-in-depth asymmetry with hint validation without restricting human-readable prose. Note: a reason containing a literal newline is now rejected with 400 (previously accepted). - Auth middleware tests parameterized across all four mutating routes, so a future route registered outside the auth group fails tests automatically. Tasks: dex tl6vr184, dex 2cka7723 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EQmqj1Hj8DL3GGAcBDNm8v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #4 (→ #3 → #2 → #1) — the last PR in the stack; merge in order.
Implements the two remaining non-blocking mediums from the principal reviews:
reasonvalidated server-side: ≤128 chars, control characters rejected with 400, free text otherwise (quotes/punctuation/unicode fine — it's operator prose, deliberately not the tight hint-identifier charset). Closes the defense-in-depth asymmetry flagged in the Tier 2 review.Review & verification
reasonhas no dashboard innerHTML sink.go vet+go test -race -count=1 ./...clean across all six packages.Tasks: dex tl6vr184, dex 2cka7723
🤖 Generated with Claude Code