Real Apple TV (tvOS) automation: dedicated TvosRobot + focus-by-identity tool#3
Closed
setoelkahfi wants to merge 3 commits into
Closed
Real Apple TV (tvOS) automation: dedicated TvosRobot + focus-by-identity tool#3setoelkahfi wants to merge 3 commits into
setoelkahfi wants to merge 3 commits into
Conversation
tvOS simulators now surface through the MCP server. - Accept `tvos` in the platform unions and validation in the mobilecli wrapper. - Drop the hard `ios` filter on simulator discovery so tvOS simulators are returned, and report each device's real platform to analytics. - List the tvOS Siri Remote buttons (UP, DOWN, LEFT, RIGHT, SELECT, MENU, PLAY_PAUSE) in the press-button tool description. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Detect physical Apple TV units by product type and report platform tvos in mobile_list_available_devices instead of hardcoding ios. Route real tvOS devices through mobilecli (which installs and drives the tvOS runner) while iPhones and iPads keep using the WebDriverAgent-based IosRobot. Add a unit test for platform detection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a dedicated TvosRobot (mobilecli/DeviceKit-backed) for real Apple TV, keeping IosRobot/WebDriverAgent unchanged for iPhone/iPad (D2). Route real Apple TVs (platform tvos) to TvosRobot via getRobotFromDevice; iOS real devices continue to IosRobot. - TvosRobot: Siri Remote buttons (UP/DOWN/LEFT/RIGHT/SELECT/MENU/ PLAY_PAUSE); app/screenshot/view-tree/screen-size delegated to mobilecli; explicit unsupported-on-tvOS ActionableErrors for tap/doubleTap/longPress/swipe/orientation/text; best-effort openUrl - New mobile_focus_by_identifier MCP tool + Mobilecli.focusByIdentifier shelling to mobilecli io focus (accessibility-identity focus) - IosManager.listDevices retains platform so routing can distinguish Apple TV; extracted and tested robotForIosDevice helper - Device-free unit tests for routing, button mapping, unsupported ops, and focus Implements: SPECS/quality/real-tvos-device-support/SPEC.md (Milestone 5, 6) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Superseded by upstream PR mobile-next#386. Keeping the branch as the source branch for upstream review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
TvosRobottomobile-mcpso real Apple TV devices are driven through mobilecli/DeviceKit with tvOS-appropriate behaviour, while leaving the existingIosRobot/WebDriverAgent path unchanged for iPhone/iPad.This is part of a three-repo change (initial PRs target the
setoelkahfiforks; upstreammobile-nextPRs are deferred until the three-repo E2E is green).What's in this PR (Milestone 5, 6)
TvosRobot(mobilecli/DeviceKit-backed): Siri Remote buttons (UP/DOWN/LEFT/RIGHT/SELECT/MENU/PLAY_PAUSE); app lifecycle, screenshot, view-tree, and screen-size delegated to mobilecli; explicitunsupported on tvOSActionableErrors fortap/doubleTap/longPress/swipe/orientation/text; best-effortopenUrlsurfacing the underlying error.platform === "tvos") route toTvosRobot; iPhones/iPads keep routing toIosRobot(WDA). Extracted + unit-testedrobotForIosDevicehelper pins the boundary.mobile_focus_by_identifierMCP tool +Mobilecli.focusByIdentifiershelling tomobilecli io focusfor accessibility-identity focus.IosManager.listDevices()now retainsplatformso the dispatcher can distinguish Apple TV.Validation
npm run build(tsc strict) passes;npm run linthas 0 source errors; newtest/tvos.tsunit tests pass. (Pre-existingtest/ios.ts/test/iphone-simulator.tsfailures are environmental — a booted tvOS simulator, no functional iPhone+WDA — and are unchanged by this PR.)Guardrails
IosRobot/WebDriverAgent behaviour is unchanged for iPhone (D2). Android/simulator routing unchanged. No hard-coded fork/user paths; public MCP response shapes are additive-only; explicit unsupported errors over silent no-ops.Implements: SPECS/quality/real-tvos-device-support/SPEC.md
Related PRs (three-repo change)