Open
Conversation
Add PEP 561 py.typed marker, mypy configuration, and include py.typed in package_data for downstream type checking support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for exceptions.py, threaded_queue.py, lru.py, provenance.py, and skeleton.py - modules with no internal deps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for lib.py (Vec, Bbox, helpers), paths.py, secrets.py, scheduler.py, chunks.py, mesh.py, and volumecutout.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for connectionpools.py, storage/storage.py, storage/storage_interfaces.py, and storage/__init__.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for cacheservice.py and datasource/precomputed/metadata.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for all precomputed datasource submodules: image (rx, tx, xfer, common, __init__), mesh (common, unsharded, metadata, multilod, __init__), skeleton (unsharded, sharded, metadata, __init__), annotation (metadata, reader, __init__), and common, mmh3, sharding, spatial_index, __init__. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type annotations for boss, n5, zarr2, zarr3, and graphene datasource modules including metadata, image, and mesh submodules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type all method signatures in CloudVolumePrecomputed and CloudVolumeGraphene classes, plus the frontends __init__.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Type cloudvolume.py (CloudVolume, SharedConfiguration, plugin registry), dask.py, server.py, and sharedmemory.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
I think this is too many changes to review at once. If it was generated by a tool that was known to be 100% correct all the time (e.g. like a compiler or linter), that would be one thing, but I'm not comfortable with large-scale changes like this otherwise. A lot of these are adding the "Any" type anyway... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude generated type annotations.
Doesn't break zutils unit tests, but might be good to test on others' code.