Allow explicit remapping of segment 0 during MeshTask#155
Open
nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
Open
Allow explicit remapping of segment 0 during MeshTask#155nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
nkemnitz wants to merge 2 commits intoseung-lab:masterfrom
Conversation
| 'compress': compress, | ||
| 'closed_dataset_edges': closed_dataset_edges, | ||
| 'dust_global': bool(dust_global), | ||
| 'remap_table': remap_table, |
Contributor
There was a problem hiding this comment.
If the remap table is big, this could cause the provenance file to become gigantic. Do we need to think about this? Maybe just record the size of the remap table above a certain size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and expose
remap_tableparameter tocreate_meshing_tasks