fix: resolve test assertion and VCR matching issues#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes test issues related to VCR cassette matching and improves a test assertion in the backtrace processor test.
Changes:
- Added
VCR_OPTIONSconstant to configure VCR to match requests only on method and URI (not body) for OpenObserve adapter tests, since payloads contain dynamic timestamps and trace IDs - Improved the "clear cache" test by populating the cache before clearing it and adding an explicit assertion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/openobserve_adapter_test.rb | Added VCR_OPTIONS constant and applied it to all VCR.use_cassette calls to avoid matching issues with dynamic payload data |
| test/backtrace_processor_test.rb | Enhanced the "clear cache" test by populating the cache first and using assert_nothing_raised for proper verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seuros
force-pushed
the
fix/test-failures
branch
2 times, most recently
from
624233d to
86f1742
Compare
seuros
force-pushed
the
fix/test-failures
branch
from
86f1742 to
e098475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.