Skip to content

Ensure required CI check reports lint failures - #266

Merged
jsgrrchg merged 1 commit into
developfrom
fix/required-ci-check-lint-failure
Aug 9, 2026
Merged

jsgrrchg merged 1 commit into
developfrom
fix/required-ci-check-lint-failure

Conversation

@jsgrrchg

@jsgrrchg jsgrrchg commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make the aggregate required check depend on both lint and test jobs
  • run the aggregate check even when an upstream job fails or is skipped
  • fail the aggregate check unless both required job results are successful

Validation

  • actionlint .github/workflows/ci.yml
  • git diff --check

Closes #262

@jsgrrchg
jsgrrchg requested a review from sewandev as a code owner August 9, 2026 09:33
@jsgrrchg
jsgrrchg merged commit b63c6b9 into develop Aug 9, 2026
7 checks passed
@jsgrrchg
jsgrrchg deleted the fix/required-ci-check-lint-failure branch August 9, 2026 15:56
@sewandev sewandev mentioned this pull request Sep 7, 2026
sewandev added a commit that referenced this pull request Sep 7, 2026
## Release v1.5.8

Version bump and changelog cut for the v1.5.8 release.

### Changes
- \Cargo.toml\ / \Cargo.lock\: version \1.5.7\ -> \1.5.8\
- \CHANGELOG.md\ / \CHANGELOG.es.md\: moved \[Unreleased]\ to \[1.5.8] -
2026-09-07\, added a fresh empty \[Unreleased]\ / \[Sin publicar]\

### Included since v1.5.7
- fix: monotonic clock for stream stall detection (#268)
- fix: serialize Spotify remote skip commands (#267)
- fix: ensure required CI check reports lint failures (#266)
- ci: separate lint job and integrate swatinem/rust-cache (#250)
- docs: add winget as the easy Windows install method (#249)
- build(deps): update Ratatui, Zip, Bytes, Clap, Rand, Thiserror and
Actions
sewandev added a commit that referenced this pull request Sep 7, 2026
## v1.5.8 release

Promotes `develop` to `main` for the v1.5.8 release.

### Included since v1.5.7
- fix: monotonic clock for stream stall detection (#268)
- fix: serialize Spotify remote skip commands (#267)
- fix: ensure required CI check reports lint failures (#266)
- ci: separate lint job and integrate swatinem/rust-cache (#250)
- docs: add winget as the easy Windows install method (#249)
- build(deps): update Ratatui, Zip, Bytes, Clap, Rand, Thiserror and
Actions

Merge with "Create a merge commit" (never squash/rebase).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Required CI check can be skipped when lint fails

1 participant