Conversation
roginvs
left a comment
There was a problem hiding this comment.
Looks good for me.
In some places it is uint32_t and in some places it is int. Should we have unit32_t everywhere?
When I added wasm build I added tests to validate outcome on RPU scripts. We can also add the same test for 64bit build
|
Yes, here is a fix for tests #23 |
|
(Note: https://github.com/BGforgeNet/VScode-BGforge-MLS/ should be able to compile using built-in sslc (wasm version) on every platform which supports vscode) |
85bd221 to
9308031
Compare
|
Added test pipeline for OS X as well as 64bit runs for linux and Windows, so hopefully this is done. Feel free to update the PR if you see anything else that could be improved. |
|
In case it is of any use, I did a similar exercise last year: #19. I had more trouble getting it working than you did! |
Since you cannot run 32-bit applications on new silicon-based MacBooks, I had to port sslc to 64-bit.
To verify that the 64-bit version produces identical bytecode I set up a build pipeline for the Restoration Project, which compiles all the scripts with both architectures and compares their checksums:
https://github.com/JanSimek/Fallout2_Restoration_Project/actions/runs/21762197911/job/62788490357
@roginvs I know you did the linux port, so maybe you could have a look at whether this looks correct to you when you have time