Repository navigation
chore(just): en Windows, las recetas que compilan la crate lanzan just vcpkg si faltan libxml2 y libxslt - #2053
Merged
Merged
Conversation
…st vcpkg` si faltan libxml2 y libxslt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué cambia
En Windows,
just bundlefallaba enbuild.rssi antes no se había lanzadojust vcpkg. Ahora las recetas que compilan la crate dependen devcpkg-libs, una receta privada que lanzajust vcpkgsolo si faltanlibxslt.libolibxml2.lib, los ficheros que exigebuild.rs. En Linux y macOS está vacía.Recetas que la llevan:
bundle(Windows),build-rust,lint-rust(y con ellacheck-rust),test-one-rust,test-windows,smoke-console,devycontract.Por qué no se llama siempre a
just vcpkgEl CI restaura
vcpkg_installed/de la caché y, si la caché acierta, no lanzajust vcpkg. Sivcpkg installcorriera siempre, un cambio de versión de vcpkg en el runner podría recompilar libxml2 y libxslt y la caché dejaría de servir. La contrapartida: si cambiavcpkg.jsoncon las bibliotecas ya compiladas, hay que lanzarjust vcpkga mano, como hasta ahora.Pruebas
just --summarycarga eljustfile.just bundlellega ajust vcpkg.