V0.2.3 sandbox hardening#4
Closed
sgr0691 wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request documents the release of Root v0.2.3, introducing significant improvements to sandbox management and resource control, as well as expanding documentation and test coverage. The main changes include strict sandbox lifecycle validation, resource limits, improved cleanup and error handling, event ledger integration, and comprehensive documentation and testing for both the sandbox and Nix subsystems.
Sandbox subsystem enhancements:
--memory,--cpus), enforced at Docker container creation.Documentation and audit:
Docs/Sandbox/V0_2_3_SANDBOX_AUDIT.md, new smoke test document, and reference notes for v0.2.3.Nix subsystem documentation:
Docs/Nix/V0_2_2_NIX_COMMAND_AUDIT.md, detailing all Nix CLI invocations, error handling, command flows, and identifying key gaps in the current implementation.Internal API and event changes:
SandboxProvidertrait andSandboxInstanceto use typed enums and new parameters for resource limits and validation.sandbox_idtoRootEventfor improved sandbox operation tracking.Bug fixes:
These changes improve reliability, traceability, and usability for sandbox operations and provide detailed documentation and audits for both sandbox and Nix-related functionality.