Fixed Bug where last file in the lcov parse would not get added to the list. - #2
Open
arjungandhi wants to merge 1 commit into
Open
Fixed Bug where last file in the lcov parse would not get added to the list. #2arjungandhi wants to merge 1 commit into
arjungandhi wants to merge 1 commit into
Conversation
Author
|
@sguiheux tagging ya so you can see this let me know if you need any more changes! |
sflanker
reviewed
Oct 18, 2024
Comment on lines
+142
to
+143
| // Add last file | ||
| report.Files = append(report.Files, fileReport) |
There was a problem hiding this comment.
While it would be unusual, I suspect it is technically legal to have an lcov file with no files listed. If that is the case this should probably be:
if fileReport.Path != "" {
report.Files = append(report.Files, fileReport)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this bug while working with the library. I've added a test case and fixed the issue