Treat the array type of vector type as a proper tensor type#736
Draft
jkwak-work wants to merge 2 commits intoshader-slang:mainfrom
Draft
Treat the array type of vector type as a proper tensor type#736jkwak-work wants to merge 2 commits intoshader-slang:mainfrom
jkwak-work wants to merge 2 commits intoshader-slang:mainfrom
Conversation
Contributor
Author
|
Fixes #638 |
jkwak-work
force-pushed
the
fix/array-of-vector-torch
branch
2 times, most recently
from
523648c to
3ff374f
Compare
jkwak-work
force-pushed
the
fix/array-of-vector-torch
branch
from
3ff374f to
e0d6c19
Compare
`is_nested_array()` was only checked for `ScalarType` and `MatrixType` and it was missing `VectorType` checking. The change from this PR effectively treats `VectorType` as a valid tensor type as it is for `ScalarType` and `MatrixType`. After discussions, the function is renamed to `castable_to_scalar` in order to reflect what it does better.
jkwak-work
force-pushed
the
fix/array-of-vector-torch
branch
from
e0d6c19 to
a274c6b
Compare
Contributor
|
This looks fairly sane, but will have to wait until after the tensor refactor is merged in, as it changes quite a bit of stuff |
Contributor
Author
|
I am going to turn this PR to a draft because:
|
Contributor
|
What's the plan with this one @jkwak-work ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_nested_array()was only checked forScalarTypeandMatrixTypeand it was missingVectorTypechecking. The change from this PR effectively treatsVectorTypeas a valid tensor type as it is forScalarTypeandMatrixType.After discussions, the function is renamed to
castable_to_scalarin order to reflect what it does better.