π‘οΈ Sentinel: [CRITICAL] Fix hardcoded admin credentials and exception leakage - #159
Conversation
Co-authored-by: shadowcoder8 <185462083+shadowcoder8@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
authenticate_adminfunction used hardcoded credentials (admin/admin123) and a non-constant time comparison operator (!=), exposing secrets in version control and creating a timing attack vulnerability. Theadmin_loginroute inmain.pyleaked internal error details in itsHTTPExceptionmessage when an unexpected error occurred.π― Impact: Attackers could easily compromise the admin account by reading the source code, or theoretically brute force passwords via timing attacks. Malicious actors could also gather internal system information if unexpected exceptions occurred during login.
π§ Fix: Removed hardcoded credentials and implemented authentication using
secrets.compare_digestwith environment variables (ADMIN_USERNAMEandADMIN_PASSWORD). Updated exception handling inmain.pyto ensure only generic error messages are returned on unexpected faults, while explicitly allowingHTTPExceptions to pass through correctly.β Verification: Tested via a custom automated script verifying that missing configs throw a 500, incorrect details throw a 401, and correct details pass. All existing tests were run and passed.
PR created automatically by Jules for task 2644715687232285276 started by @shadowcoder8