π‘οΈ Sentinel: [MEDIUM] Fix exception handling information leak in admin login - #168
π‘οΈ Sentinel: [MEDIUM] Fix exception handling information leak in admin login#168shadowcoder8 wants to merge 1 commit into
Conversation
Co-authored-by: shadowcoder8 <185462083+shadowcoder8@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: The
admin_loginroute was explicitly catching all exceptions and returning their internalstr(e)representation in a 401 response payload.π― Impact: This violated the "fail securely" principle and allowed potential Information Exposure (CWE-209) to attackers if internal systems (like DB or config) threw unexpected errors.
π§ Fix: Explicitly caught intended
HTTPExceptions to re-raise them correctly, while catching generalExceptions separately to return a generic 500 "Internal server error" while maintaining logging.β Verification: An ad-hoc test was created, verified, and deleted, passing
fastapi.testclient.TestClientresponses to confirm generic exceptions no longer leak data, andpytestwas run to ensure no regressions. The Sentinel journal was also updated to record this learning.PR created automatically by Jules for task 3329980495604193158 started by @shadowcoder8