π‘οΈ Sentinel: [HIGH] Fix authorization bypass in API - #173
π‘οΈ Sentinel: [HIGH] Fix authorization bypass in API#173shadowcoder8 wants to merge 1 commit into
Conversation
Co-authored-by: shadowcoder8 <185462083+shadowcoder8@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Core API endpoints (such as
/labours/,/attendance/,/materials/,/sites/,/payments/) and their management pages were missing authentication checks. Anyone could access and modify sensitive data without being authenticated.π― Impact: Unauthenticated users could view and modify sensitive database records without valid sessions, leading to complete authorization bypass.
π§ Fix: Added
dependencies=[Depends(get_current_user)]to core API endpoints inmain.pyusing standard FastAPI dependency injection to enforce that a valid session exists. Excluded public and already-authenticated routes. Also appended the learning to.jules/sentinel.md.β Verification: Verified using
verify_auth.pythat endpoints return401 Unauthorizedwhen requested without valid session cookies. All unit tests successfully passed.PR created automatically by Jules for task 17021241007067885048 started by @shadowcoder8