🛡️ Sentinel: [CRITICAL] Fix missing authentication on core API endpoints - #176
🛡️ Sentinel: [CRITICAL] Fix missing authentication on core API endpoints#176shadowcoder8 wants to merge 1 commit into
Conversation
Co-authored-by: shadowcoder8 <185462083+shadowcoder8@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Severity: CRITICAL
Vulnerability: Several core API endpoints (
/labours/,/attendance/,/materials/,/sites/, and/payments/) and management routes were exposed without authentication, allowing unauthenticated users to perform administrative actions.Impact: Unauthorized users could potentially read, create, modify, or delete sensitive data across all major modules of the application.
Fix: Added
dependencies=[Depends(get_current_user)]to all relevant unauthenticated FastAPI route decorators inmain.py.Verification: Reviewed
main.pydiff to ensure the dependencies were successfully added to all protected routes without interfering with public paths. All backend pytest unit tests passed confirming that internal functionality works properly. Also added the fix details to.jules/sentinel.mdjournal.PR created automatically by Jules for task 2204499578070148971 started by @shadowcoder8