π‘οΈ Sentinel: [CRITICAL] Fix missing authentication on API endpoints - #177
π‘οΈ Sentinel: [CRITICAL] Fix missing authentication on API endpoints#177shadowcoder8 wants to merge 1 commit into
Conversation
Co-authored-by: shadowcoder8 <185462083+shadowcoder8@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Missing authentication decorators on sensitive API endpoints (e.g.,
/labours/,/attendance/,/materials/,/sites/,/payments/) and management routes.π― Impact: Unauthenticated users could view, create, update, or delete sensitive data and access management pages, leading to massive data leaks and integrity loss.
π§ Fix: Added
dependencies=[Depends(get_current_user)]to all relevant route decorators inmain.pyto enforce authentication globally across sensitive paths.β Verification: Verified via tests checking that unauthenticated requests to
/labours/return a 401 Unauthorized status, and confirmed the change does not break the test suite. Also updated the Sentinel journal with these learnings.PR created automatically by Jules for task 14299686520343718446 started by @shadowcoder8